-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat] 프로필 생성 UI 제작 #58
Conversation
…eature/create-profile-create-ui
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
빡작업하느라 고생했어용~!! 👍👍👍
코멘트 몇 개만 봐주세용
core/designsystem/src/main/java/com/moya/funch/common/SearchPainter.kt
Outdated
Show resolved
Hide resolved
feature/profile/src/main/java/com/moya/funch/CreatePofileViewModel.kt
Outdated
Show resolved
Hide resolved
feature/profile/src/main/java/com/moya/funch/CreatePofileViewModel.kt
Outdated
Show resolved
Hide resolved
…eature/create-profile-create-ui # Conflicts: # app/src/main/AndroidManifest.xml
@murjune #50 (comment) 해당 이슈들 다 해결하고 여기 PR 종료하려고 하는데 어떻게 생각해? |
@ham2174 이 부분은 detail 적인 부분이여서 나중에 fix 브랜치 하나 파서 진행하는거 어떤가유?? |
그러면 해당 이슈들을 모은 새로운 이슈 생성하고 이 PR은 머지할게?! @murjune |
…eature/create-profile-create-ui
관련 이슈
작업한 내용
FunchButton
: Full, Large 타입 ContentVerticalPadding 피그마와 일치하게끔 변경FunchTextField
4종FunchFeedbackButton
: internal → public으로 변경FunchLabel
: 신규 컴포넌트 제작PR 포인트
Screen_recording_20240212_220028.mp4.mp4